Browse Source

Refactor ControlRequest and ControlResponse.

wip
Titouan Rigoudy 9 years ago
parent
commit
d1d6981a43
4 changed files with 21 additions and 21 deletions
  1. +8
    -8
      src/client.rs
  2. +11
    -11
      src/control/controller.rs
  3. +1
    -1
      src/control/request.rs
  4. +1
    -1
      src/control/response.rs

+ 8
- 8
src/client.rs View File

@ -12,7 +12,7 @@ use room;
#[derive(Debug)] #[derive(Debug)]
enum IncomingMessage { enum IncomingMessage {
ServerResponse(ServerResponse), ServerResponse(ServerResponse),
ControlRequest(control::ControlRequest),
ControlRequest(control::Request),
} }
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
@ -26,8 +26,8 @@ pub struct Client {
proto_tx: mio::Sender<Request>, proto_tx: mio::Sender<Request>,
proto_rx: mpsc::Receiver<Response>, proto_rx: mpsc::Receiver<Response>,
control_tx: mpsc::Sender<control::ControlResponse>,
control_rx: mpsc::Receiver<control::ControlRequest>,
control_tx: mpsc::Sender<control::Response>,
control_rx: mpsc::Receiver<control::Request>,
login_status: LoginStatus, login_status: LoginStatus,
@ -39,8 +39,8 @@ impl Client {
pub fn new( pub fn new(
proto_tx: mio::Sender<Request>, proto_tx: mio::Sender<Request>,
proto_rx: mpsc::Receiver<Response>, proto_rx: mpsc::Receiver<Response>,
control_tx: mpsc::Sender<control::ControlResponse>,
control_rx: mpsc::Receiver<control::ControlRequest>)
control_tx: mpsc::Sender<control::Response>,
control_rx: mpsc::Receiver<control::Request>)
-> Self -> Self
{ {
Client { Client {
@ -92,9 +92,9 @@ impl Client {
} }
} }
fn handle_control_request(&mut self, request: control::ControlRequest) {
fn handle_control_request(&mut self, request: control::Request) {
match request { match request {
control::ControlRequest::LoginStatusRequest =>
control::Request::LoginStatusRequest =>
self.handle_login_status_request(), self.handle_login_status_request(),
_ =>{ _ =>{
@ -123,7 +123,7 @@ impl Client {
}, },
}; };
debug!("Sending control response: {:?}", response); debug!("Sending control response: {:?}", response);
self.control_tx.send(control::ControlResponse::LoginStatusResponse(response));
self.control_tx.send(control::Response::LoginStatusResponse(response));
} }
fn handle_server_response(&mut self, response: ServerResponse) { fn handle_server_response(&mut self, response: ServerResponse) {


+ 11
- 11
src/control/controller.rs View File

@ -28,7 +28,7 @@ enum Error {
IOError(io::Error), IOError(io::Error),
JSONEncoderError(json::EncoderError), JSONEncoderError(json::EncoderError),
JSONDecoderError(json::DecoderError), JSONDecoderError(json::DecoderError),
SendError(mpsc::SendError<ControlRequest>),
SendError(mpsc::SendError<Request>),
Utf8Error(str::Utf8Error), Utf8Error(str::Utf8Error),
WebSocketError(websocket::result::WebSocketError), WebSocketError(websocket::result::WebSocketError),
} }
@ -70,8 +70,8 @@ impl From<json::DecoderError> for Error {
} }
} }
impl From<mpsc::SendError<ControlRequest>> for Error {
fn from(err: mpsc::SendError<ControlRequest>) -> Self {
impl From<mpsc::SendError<Request>> for Error {
fn from(err: mpsc::SendError<Request>) -> Self {
Error::SendError(err) Error::SendError(err)
} }
} }
@ -89,13 +89,13 @@ impl From<websocket::result::WebSocketError> for Error {
} }
pub struct Controller { pub struct Controller {
client_tx: mpsc::Sender<ControlRequest>,
client_rx: mpsc::Receiver<ControlResponse>,
client_tx: mpsc::Sender<Request>,
client_rx: mpsc::Receiver<Response>,
} }
impl Controller { impl Controller {
pub fn new(tx: mpsc::Sender<ControlRequest>,
rx: mpsc::Receiver<ControlResponse>)
pub fn new(tx: mpsc::Sender<Request>,
rx: mpsc::Receiver<Response>)
-> Self -> Self
{ {
Controller { Controller {
@ -150,7 +150,7 @@ impl Controller {
fn receiver_loop( fn receiver_loop(
mut receiver: WebSocketReceiver, mut receiver: WebSocketReceiver,
client_tx: mpsc::Sender<ControlRequest>,
client_tx: mpsc::Sender<Request>,
sender_tx: mpsc::Sender<()>) sender_tx: mpsc::Sender<()>)
{ {
for message_result in receiver.incoming_messages() { for message_result in receiver.incoming_messages() {
@ -186,7 +186,7 @@ impl Controller {
fn handle_text_message( fn handle_text_message(
payload_bytes: &[u8], payload_bytes: &[u8],
client_tx: &mpsc::Sender<ControlRequest>)
client_tx: &mpsc::Sender<Request>)
-> Result<(), Error> -> Result<(), Error>
{ {
let payload = try!(str::from_utf8(payload_bytes)); let payload = try!(str::from_utf8(payload_bytes));
@ -197,7 +197,7 @@ impl Controller {
fn sender_loop( fn sender_loop(
mut sender: WebSocketSender, mut sender: WebSocketSender,
client_rx: &mut mpsc::Receiver<ControlResponse>,
client_rx: &mut mpsc::Receiver<Response>,
sender_rx: mpsc::Receiver<()>) sender_rx: mpsc::Receiver<()>)
{ {
loop { loop {
@ -224,7 +224,7 @@ impl Controller {
sender.shutdown_all().unwrap(); sender.shutdown_all().unwrap();
} }
fn send_response(sender: &mut WebSocketSender, response: ControlResponse)
fn send_response(sender: &mut WebSocketSender, response: Response)
-> Result<(), Error> -> Result<(), Error>
{ {
let encoded = try!(json::encode(&response)); let encoded = try!(json::encode(&response));


+ 1
- 1
src/control/request.rs View File

@ -1,5 +1,5 @@
#[derive(Debug, RustcDecodable, RustcEncodable)] #[derive(Debug, RustcDecodable, RustcEncodable)]
pub enum ControlRequest {
pub enum Request {
LoginStatusRequest, LoginStatusRequest,
RoomListRequest, RoomListRequest,
} }

+ 1
- 1
src/control/response.rs View File

@ -1,7 +1,7 @@
use room; use room;
#[derive(Debug, RustcDecodable, RustcEncodable)] #[derive(Debug, RustcDecodable, RustcEncodable)]
pub enum ControlResponse {
pub enum Response {
LoginStatusResponse(LoginStatusResponse), LoginStatusResponse(LoginStatusResponse),
RoomListResponse(RoomListResponse), RoomListResponse(RoomListResponse),
} }


Loading…
Cancel
Save