Squash a bunch of warnings with allow attributes.

src/client.rs

@@ -16,17 +16,23 @@ use crate::user;
 #[derive(Debug)]
 enum IncomingMessage {
     Proto(proto::Response),
+
+    #[allow(dead_code)]
     ControlNotification(control::Notification),
 }
 
 #[derive(Debug)]
 enum PeerState {
     /// We are trying to establish a direct connection.
+    #[allow(dead_code)]
     Opening,
+
     /// We are trying to establish a reverse connection.
     OpeningFirewalled,
+
     /// We are waiting for a reverse connection to be established to us.
     WaitingFirewalled,
+
     /// The connection is open.
     Open,
 }
@@ -42,10 +48,13 @@ struct Peer {
 }
 
 pub struct Client {
+    #[allow(deprecated)]
     proto_tx: mio::deprecated::Sender<proto::Request>,
     proto_rx: crossbeam_channel::Receiver<proto::Response>,
 
     control_tx: Option<control::Sender>,
+
+    #[allow(dead_code)]
     control_rx: crossbeam_channel::Receiver<control::Notification>,
 
     login_status: LoginStatus,
@@ -60,6 +69,7 @@ impl Client {
     /// Returns a new client that will communicate with the protocol agent
     /// through `proto_tx` and `proto_rx`, and with the controller agent
     /// through `control_rx`.
+    #[allow(deprecated)]
     pub fn new(
         proto_tx: mio::deprecated::Sender<proto::Request>,
         proto_rx: crossbeam_channel::Receiver<proto::Response>,
@@ -121,6 +131,7 @@ impl Client {
 
     /// Send a request to the server.
     fn send_to_server(&self, request: server::ServerRequest) {
+        #[allow(deprecated)]
         self.proto_tx
             .send(proto::Request::ServerRequest(request))
             .unwrap();
@@ -128,6 +139,7 @@ impl Client {
 
     /// Send a message to a peer.
     fn send_to_peer(&self, peer_id: usize, message: peer::Message) {
+        #[allow(deprecated)]
         self.proto_tx
             .send(proto::Request::PeerMessage(peer_id, message))
             .unwrap();
@@ -135,6 +147,7 @@ impl Client {
 
     /// Send a response to the controller client.
     fn send_to_controller(&mut self, response: control::Response) {
+        #[allow(deprecated)]
         let result = match self.control_tx {
             None => {
                 // Silently drop control requests when controller is
@@ -347,6 +360,7 @@ impl Client {
                 let peer = occupied_entry.get_mut();
                 peer.state = PeerState::WaitingFirewalled;
 
+                #[allow(deprecated)]
                 self.proto_tx
                     .send(proto::Request::ServerRequest(
                         server::ServerRequest::ConnectToPeerRequest(server::ConnectToPeerRequest {
@@ -365,6 +379,7 @@ impl Client {
                 );
 
                 let (peer, _) = occupied_entry.remove();
+                #[allow(deprecated)]
                 self.proto_tx
                     .send(proto::Request::ServerRequest(
                         server::ServerRequest::CannotConnectRequest(server::CannotConnectRequest {
@@ -522,6 +537,7 @@ impl Client {
                     "Opening peer connection {} to {}:{} to pierce firewall",
                     peer_id, response.ip, response.port
                 );
+                #[allow(deprecated)]
                 self.proto_tx
                     .send(proto::Request::PeerConnect(
                         peer_id,

src/control/ws.rs

@@ -51,7 +51,7 @@ impl error::Error for SendError {
         }
     }
 
-    fn cause(&self) -> Option<&error::Error> {
+    fn cause(&self) -> Option<&dyn error::Error> {
         match *self {
             SendError::JSONEncoderError(ref err) => Some(err),
             SendError::WebSocketError(ref err) => Some(err),

src/handlers/login_handler.rs

@@ -9,7 +9,7 @@ use crate::proto::server::LoginResponse;
 pub struct LoginHandler;
 
 impl MessageHandler<LoginResponse> for LoginHandler {
-    fn run(self, context: &Context, message: &LoginResponse) -> io::Result<()> {
+    fn run(self, context: &Context, _message: &LoginResponse) -> io::Result<()> {
         let lock = context.login.lock();
 
         match *lock {

src/message_handler.rs

@@ -1,4 +1,3 @@
-use std::fmt::Debug;
 use std::io;
 
 use crate::context::Context;

src/proto/handler.rs

@@ -116,6 +116,7 @@ where
 }
 
 impl Handler {
+    #[allow(deprecated)]
     fn new(
         client_tx: crossbeam_channel::Sender<Response>,
         event_loop: &mut mio::deprecated::EventLoop<Self>,
@@ -158,6 +159,7 @@ impl Handler {
         })
     }
 
+    #[allow(deprecated)]
     fn connect_to_peer(
         &mut self,
         peer_id: usize,
@@ -202,6 +204,7 @@ impl Handler {
         Ok(())
     }
 
+    #[allow(deprecated)]
     fn process_server_intent(
         &mut self,
         intent: Intent,
@@ -225,6 +228,7 @@ impl Handler {
         }
     }
 
+    #[allow(deprecated)]
     fn process_peer_intent(
         &mut self,
         intent: Intent,
@@ -255,6 +259,7 @@ impl Handler {
     }
 }
 
+#[allow(deprecated)]
 impl mio::deprecated::Handler for Handler {
     type Timeout = ();
     type Message = Request;
@@ -342,9 +347,11 @@ impl mio::deprecated::Handler for Handler {
     }
 }
 
+#[allow(deprecated)]
 pub type Sender = mio::deprecated::Sender<Request>;
 
 pub struct Agent {
+    #[allow(deprecated)]
     event_loop: mio::deprecated::EventLoop<Handler>,
     handler: Handler,
 }
@@ -352,6 +359,7 @@ pub struct Agent {
 impl Agent {
     pub fn new(client_tx: crossbeam_channel::Sender<Response>) -> io::Result<Self> {
         // Create the event loop.
+        #[allow(deprecated)]
         let mut event_loop = mio::deprecated::EventLoop::new()?;
         // Create the handler for the event loop and register the handler's
         // sockets with the event loop.
@@ -364,10 +372,12 @@ impl Agent {
     }
 
     pub fn channel(&self) -> Sender {
+        #[allow(deprecated)]
         self.event_loop.channel()
     }
 
     pub fn run(&mut self) -> io::Result<()> {
+        #[allow(deprecated)]
         self.event_loop.run(&mut self.handler)
     }
 }

src/proto/packet.rs

@@ -8,6 +8,7 @@ use std::net;
 use byteorder::{ByteOrder, LittleEndian, ReadBytesExt, WriteBytesExt};
 use encoding::all::ISO_8859_1;
 use encoding::{DecoderTrap, EncoderTrap, Encoding};
+#[allow(deprecated)]
 use mio::deprecated::TryRead;
 
 use super::constants::*;
@@ -155,7 +156,7 @@ impl error::Error for PacketReadError {
         }
     }
 
-    fn cause(&self) -> Option<&error::Error> {
+    fn cause(&self) -> Option<&dyn error::Error> {
         match *self {
             PacketReadError::InvalidBoolError(_) => None,
             PacketReadError::InvalidU16Error(_) => None,
@@ -361,6 +362,8 @@ impl Parser {
         // Try to read as many bytes as we currently need from the underlying
         // byte stream.
         let offset = self.buffer.len() - self.num_bytes_left;
+
+        #[allow(deprecated)]
         match stream.try_read(&mut self.buffer[offset..])? {
             None => (),
 

src/proto/peer/message.rs

@@ -155,8 +155,6 @@ impl ValueDecode for PeerInit {
 
 #[cfg(test)]
 mod tests {
-    use std::io;
-
     use bytes::BytesMut;
 
     use crate::proto::value_codec::tests::roundtrip;

src/proto/server/request.rs

@@ -586,8 +586,6 @@ impl ValueDecode for UserStatusRequest {
 
 #[cfg(test)]
 mod tests {
-    use std::io;
-
     use bytes::BytesMut;
 
     use crate::proto::value_codec::tests::roundtrip;

src/proto/server/response.rs

@@ -1,4 +1,3 @@
-use std::io;
 use std::net;
 
 use crate::proto::packet::{Packet, PacketReadError, ReadFromPacket};
@@ -1337,7 +1336,6 @@ impl ValueDecode for WishlistIntervalResponse {
 
 #[cfg(test)]
 mod tests {
-    use std::io;
     use std::net;
 
     use bytes::BytesMut;

src/proto/stream.rs

@@ -39,6 +39,7 @@ impl OutBuf {
         self.remaining() > 0
     }
 
+    #[allow(deprecated)]
     fn try_write_to<T>(&mut self, mut writer: T) -> io::Result<Option<usize>>
     where
         T: mio::deprecated::TryWrite,
@@ -167,6 +168,7 @@ impl<T: SendPacket> Stream<T> {
 
     /// The stream is ready to read, write, or both.
     pub fn on_ready(&mut self, event_set: mio::Ready) -> Intent {
+        #[allow(deprecated)]
         if event_set.is_hup() || event_set.is_error() {
             return Intent::Done;
         }
@@ -198,6 +200,7 @@ impl<T: SendPacket> Stream<T> {
         }
 
         // We're always interested in reading more.
+        #[allow(deprecated)]
         let mut event_set = mio::Ready::readable() | mio::Ready::hup() | mio::Ready::error();
         // If there is still stuff to write in the queue, we're interested in
         // the socket becoming writable too.

src/proto/value_codec.rs

@@ -465,7 +465,6 @@ impl<T: ValueEncode> ValueEncode for Vec<T> {
 #[cfg(test)]
 pub mod tests {
     use std::fmt;
-    use std::io;
     use std::net;
     use std::u16;
     use std::u32;